build(prettier): fixed endOfLine param & exclusions in css packages #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeb
previously approved these changes
Jan 10, 2024
pplancq
reviewed
Jan 10, 2024
pplancq
reviewed
Jan 10, 2024
JLou
force-pushed
the
fix-prettier-config
branch
from
17ced4f to
69f8ff2
Compare
pplancq
reviewed
Jan 10, 2024
JLou
force-pushed
the
fix-prettier-config
branch
from
69f8ff2 to
059ed16
Compare
pplancq
reviewed
Jan 12, 2024
There was a problem hiding this comment.
pourquoi ce nom en particulier ? Y a tout cela qui sont possibles : https://prettier.io/docs/en/configuration.html
Y a une limitation particuliere pour les autres ?
There was a problem hiding this comment.
c'est juste moi j'ai mis .eslintrc dans les packages donc juste pour la cohérence après ca ne me dérange pas plus que ca
There was a problem hiding this comment.
tu n'as pas update les npm script prettier comme sur le package css ? est normale ?
Ouais, niveau plugin IDE c'était pris en compte et n'appliquait pas prettier sur le onSave dans les fichiers ts. |
samuel-gomez
approved these changes
Jan 12, 2024
pplancq
approved these changes
Jan 12, 2024
Triki-Ahmed
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier voulait forcer nos endOfLine à lf. Mais vu qu'on fait du git, cette règle n'a pas de sens vu qu'on à
core.autocrlf=truesur windows, et sur unix on a du lf par défaut.Aussi, prettier sur le package css voulait lancer prettier sur des fichiers qui n'auraient pas du l'être, ils sont donc dans le prettierignore maintenant.
Enfin, le precommit hook tente de lancer prettier sur chaque fichier dans le stage qui n'est ni ts/js/css, sauf que par exemple un .prettierignore matchait. Donc pour l'instant on formatte que les mdx.